-
Notifications
You must be signed in to change notification settings - Fork 4k
[PS] Migrate StreamAnalytics module to autorest v4 #28316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
To the author of the pull request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the StreamAnalytics module to AutoRest v4, upgrading the code generator to introduce various new features. The migration updates model type references, parameter types, and adds new parameter sets for JSON file/string inputs.
Key changes include:
- Model namespace updates from API-specific to generic model types
- Parameter type changes from strongly-typed enums to string types
- Addition of new parameter sets supporting JSON file and string inputs
Reviewed Changes
Copilot reviewed 98 out of 99 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tools/StaticAnalysis/Exceptions/Az.StreamAnalytics/BreakingChangeIssues.csv | Documents breaking changes from the v4 migration including type changes and parameter modifications |
src/StreamAnalytics/StreamAnalytics/help/*.md | Updates help documentation to reflect new model types and parameter sets |
src/StreamAnalytics/StreamAnalytics.Autorest/test/*.ps1 | Fixes file path separators in test files from backslashes to forward slashes |
src/StreamAnalytics/StreamAnalytics.Autorest/custom/*.ps1 | Updates custom cmdlets to use new model type references |
src/StreamAnalytics/StreamAnalytics.Autorest/examples/*.md | Corrects filename typos from "StroageAccount.json" to "StorageAccount.json" |
@@ -111,10 +111,10 @@ function setupEnv() { | |||
$iothubKey = $resourceKey.PrimaryKey | |||
|
|||
# Update value of the template json. | |||
$storageAccountParam = Get-Content .\test\template-json\StroageAccount.json | ConvertFrom-Json | |||
$storageAccountParam = Get-Content .\test\template-json\StorageAccount.json | ConvertFrom-Json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename 'StorageAccount.json' was corrected from the misspelled 'StroageAccount.json', but this correction needs to be consistently applied throughout the codebase.
Copilot uses AI. Check for mistakes.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.